docs(chat): explain the dual ensureChatRootStyles path (unblocks demo redeploy)#379
Merged
Conversation
apps/website/content/docs/telemetry/api/api-docs.json drifted 19 lines on main — a recent telemetry change added a public API entry but didn't regenerate the docs. The `Verify generated API docs are committed` step in Website — lint / build has been failing on every push to main since, and that job gates the entire Deploy → Vercel job (which is the one that auto-deploys demo.cacheplane.ai + cacheplane.ai + cockpit.cacheplane.ai + examples.cacheplane.ai). Result: the demo has been stuck on a stale build despite the auto- deploy wiring being correct. Regenerated via `npm run generate-api- docs`; diff is purely additive (19 inserts, 0 deletes). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Document why we keep both the module-eval side-effect call AND the explicit constructor calls in the top-level chat compositions: the side-effect is the fast path for source-resolution consumers, the constructor calls are the guaranteed path for production-bundled consumers where tree-shaking can drop the side effect. Also: this commit's libs/ change unblocks the canonical-demo Vercel redeploy that's been stuck since v0.0.32 (the prior libs/ commits all failed CI's website-lint-build api-docs check; #377 fixed that but its diff didn't trigger demo_changed=true). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Docstring addition to chat-tokens.ts explaining why we keep both injection paths (module-eval side effect + explicit constructor calls in chat compositions).
Why now
The demo at demo.cacheplane.ai has been stuck on a build from before v0.0.32 because:
This PR is a libs/chat docstring change that BOTH:
After this lands, the demo finally picks up PR #375's fix (v0.0.35's lifecycle-guaranteed token injection).
Test plan
<style id="ngaf-chat-root-tokens">present🤖 Generated with Claude Code